Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0.1] [CMake] [Darwin] Don't build the SDK overlays by default on Apple platforms #76581

Conversation

ian-twilightcoder
Copy link
Contributor

The Apple SDKs have been providing the Darwin overlay since macOS 10.14.4, iOS 12.2, et al. More recently the SDK version has diverged from the Swift version making them incompatible. Stop building the overlay from Swift. Once the SDK overlays aren't being built, the clang overlays need to be built in testing.

rdar://115192929

…pple platforms

The Apple SDKs have been providing the Darwin overlay since macOS 10.14.4, iOS 12.2, et al. More recently the SDK version has diverged from the Swift version making them incompatible. Stop building the overlay from Swift. Once the SDK overlays aren't being built, the clang overlays need to be built in testing.

rdar://115192929
@ian-twilightcoder ian-twilightcoder requested a review from a team as a code owner September 19, 2024 19:39
@ian-twilightcoder
Copy link
Contributor Author

Explanation: This change is required for open source Swift to compile using and support compiling against the SDKs in Xcode 16.
Radar (and possibly SR Issue): rdar://115192929
Scope: Building on Apple platforms.
Risk: freestanding/embedded are still not able to build their tests (followup in #76461), but this allows the compiler and stdlib to build.
Testing: CI, building Swift locally.
Reviewed By: Eric Miotto (edymtt)

@ian-twilightcoder
Copy link
Contributor Author

@swift-ci test

@ian-twilightcoder ian-twilightcoder merged commit 6ac546a into swiftlang:release/6.0.1 Sep 20, 2024
5 checks passed
@ian-twilightcoder ian-twilightcoder deleted the dont-build-overlays-on-apple_601 branch November 1, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants