Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parse] Restrict parsing integer types in certain contexts #76553

Closed

Conversation

Azoy
Copy link
Contributor

@Azoy Azoy commented Sep 18, 2024

Previously, we would unconditionally parse integers as types in all contexts that were expecting to parse types. This patch changes that behavior so that we only parse integers as types in the contexts where we expect to see valid usages of these types, namely as generic arguments and as either the LHS or RHS of a same type generic constraint.

@Azoy
Copy link
Contributor Author

Azoy commented Sep 18, 2024

@swift-ci please smoke test

@Azoy
Copy link
Contributor Author

Azoy commented Sep 18, 2024

@swift-ci please smoke test

Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good to me.

@Azoy Azoy requested a review from jckarter as a code owner September 19, 2024 18:16
@Azoy
Copy link
Contributor Author

Azoy commented Sep 19, 2024

@swift-ci please smoke test

@Azoy
Copy link
Contributor Author

Azoy commented Oct 22, 2024

Closing in favor of #77149 which will include these changes.

@Azoy Azoy closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants