Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lldb] Add a hint for potential missing module imports in the express… #9560

Merged
merged 1 commit into from
Nov 12, 2024
Merged

[lldb] Add a hint for potential missing module imports in the express… #9560

merged 1 commit into from
Nov 12, 2024

Conversation

adrian-prantl
Copy link

…ion evaluator

@adrian-prantl
Copy link
Author

@swift-ci test

augusto2112
augusto2112 approved these changes Nov 9, 2024
View reviewed changes
Copy link

@augusto2112 augusto2112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the drive-by conversions to llvm::Expected

lldb/source/Plugins/ExpressionParser/Swift/SwiftExpressionParser.cpp Outdated Show resolved Hide resolved
lldb/source/Plugins/ExpressionParser/Swift/SwiftExpressionParser.cpp Show resolved Hide resolved
lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp Show resolved Hide resolved
lldb/test/API/lang/swift/expression/error_missing_type/TestSwiftExpressionErrorMissingType.py Outdated Show resolved Hide resolved
@adrian-prantl adrian-prantl force-pushed the module-import-hint branch 2 times, most recently from 763fc50 to 7c61936 Compare November 11, 2024 18:35
@adrian-prantl
Copy link
Author

@swift-ci test

@adrian-prantl
Copy link
Author

@swift-ci test

@adrian-prantl
Copy link
Author

@swift-ci test

@adrian-prantl
Copy link
Author

@swift-ci test

@adrian-prantl adrian-prantl merged commit 5232c25 into swiftlang:stable/20240723 Nov 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augusto2112 augusto2112 augusto2112 approved these changes

@JDevlieghere JDevlieghere Awaiting requested review from JDevlieghere JDevlieghere is a code owner

@kastiglione kastiglione Awaiting requested review from kastiglione

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrian-prantl @augusto2112