Add profiling messages [AP-650] #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodfell
force-pushed
the
woodfell/native_thread_profiling
branch
from
e95f2ce
to
470c354
Compare
woodfell
changed the title
woodfell
requested review from
jungleraptor,
a team,
notoriaga and
pcrumley
as code owners
|
pcrumley
reviewed
Feb 5, 2024
Comment on lines
+152
to
+156
| id: 0xCF03 | ||
| short_desc: Information about resource buckets | ||
| desc: > | ||
| Information about resource buckets. Refer to product documentation to understand | ||
| the meaning and values in this message. |
There was a problem hiding this comment.
is this description correct? I guess it contains buckets but not exactly what I was expecting give the message name
reimerix
approved these changes
Feb 15, 2024
woodfell
force-pushed
the
woodfell/native_thread_profiling
branch
from
470c354
to
99701e0
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@swift-nav/devinfra
Add definitions and tests for 3 new messages
MSG_PROFILING_RESOURCE_COUNTERMSG_PROFILING_SYSTEM_INFOMSG_PROFILING_THREAD_INFOThese messages are not intended for wide public use, the definitions and significance are defined elsewhere
As always, only the changes under the
specdirectory are interesting, everything else is generatedAPI compatibility
Does this change introduce a API compatibility risk?
No
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
N/A
JIRA Reference
https://swift-nav.atlassian.net/browse/AP-650