Add MsgMeasurementPoint [AP-653] #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodfell
force-pushed
the
woodfell/dedicated_profiling_msg
branch
from
babc7c4
to
0ab7335
Compare
woodfell
force-pushed
the
woodfell/dedicated_profiling_msg
branch
2 times, most recently
from
718003c
to
ae709c5
Compare
woodfell
requested review from
jungleraptor,
a team,
notoriaga and
pcrumley
as code owners
richarddeurloo
approved these changes
Dec 20, 2023
| "slice_time": 261963842, "line": 18, "func": "route()\u0000", | ||
| "payload": "+gcAALQAAgAAACgAAACCyZSNYVUAABKCyZQAAAAAQkCdDwAAAAASAHJvdXRlKCkA" | ||
| }' | ||
|
|
There was a problem hiding this comment.
Nit: this new line seems unnecessary.
woodfell
force-pushed
the
woodfell/dedicated_profiling_msg
branch
from
ae709c5
to
0bae518
Compare
pcrumley
approved these changes
Jan 3, 2024
woodfell
force-pushed
the
woodfell/dedicated_profiling_msg
branch
from
0bae518
to
e05062e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@swift-nav/devinfra
Create a new message to output profiling information from measurement points.
Current version of some product will output measurement point profiling information in the LinuxCPUState message making use of the
cmdlinefield to serialise various bits of information. Some other bits of information are placed in to the other fields in LinuxCpuState but since the fields are already defined the names are misleading.This PR introduces a dedicated message which contains the same information as is currently sent but broken out in to fields with the correct types. This removes the need to serialise/deserialise this information once products are updated to use this message instead.
API compatibility
Does this change introduce a API compatibility risk?
No
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
No
JIRA Reference
https://swift-nav.atlassian.net/browse/AP-653