rust: ability to convert to common serde map structure #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverjam
requested review from
notoriaga,
pcrumley,
jungleraptor and
a team
as code owners
pcrumley
requested changes
Jul 13, 2023
|
@pcrumley This looking better? |
pcrumley
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Hey @silverjam I was hoping to see something like what I did in this stacked PR. #1349
See what you think, you can just merge that pr into this or change it however you'd like. I think it is worth making sure JsonOutput is constructed the same throughout the lib, but i'm ok either way
silverjam
changed the title
@silverjam this is an example of the change I wanted to see. Whenever JsonOutput is created it should be done by the same function. Therefore if it ever is refactored there will be no drft.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new API function to return a serde_json::Value type that corresponds to what we get when running sbp2json -- this enables functionality that requires access to a JSON like object (with all the associated message data) without requiring that we parse JSON.
See here for an example usage: https://github.com/swift-nav/sbp-filter/pull/122
API compatibility
No API compatibility issues since we're just adding a new function.
JIRA Reference
https://swift-nav.atlassian.net/browse/DIP-2