perf: Using better string cache
#6893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IWANABETHATGUY
force-pushed
the
chore/better-string-cache
branch
from
ed45b39
to
3b14e48
Compare
kdy1
requested changes
Feb 1, 2023
| @@ -28,7 +28,7 @@ rkyv = { package = "rkyv", version = "=0.7.37", optional = true } | |||
| rkyv-latest = { package = "rkyv-test", version = "=0.7.38-test.2", optional = true } | |||
| rustc-hash = "1.1.0" | |||
| serde = "1" | |||
| string_cache = "0.8.4" | |||
| string_cache = { git = "https://github.com/swc-project/string-cache", branch = "swc" } | |||
There was a problem hiding this comment.
Could we reuse the repo and publish a string-cache of SWC version? Something like string-cache-swc.
For some reason, I guess they(string-cache) just don't want to change anything. servo/string-cache#265
There was a problem hiding this comment.
Yes, but I think you can use patch section of cargo to use it, and changing string_cache with something different is a breaking change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Using better string-cache
The latest
Muteximplementation is faster thanparking_lot, especially when locking contention is heavy,rust-lang/rust#95035 (comment),
This could have a huge performance improvement when using swc in some parallel scenarios, like bundler.
BREAKING CHANGE:
Related issue (if exists):