input/keyboard: extend bindsym --to-code to work with duplicate matches #8358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
to test: swaymsg 'input * xkb_layout us'
swaymsg 'bindsym --to-code $mod1+a exec notify-send hi'
# test that alt+a sends hi according to a US QWERTY layout
swaymsg 'input * xkb_layout fr'
# Test that alt+q now sends hi, as the French AZERTY layout is the new
# "first configured layout" that `--to-code` should respect
swaymsg 'input * xkb_layout us'
swaymsg 'bindsym --to-code Print+a exec notify-send hi'
# test that Print+a sends hi according to a US QWERTY layout
swaymsg 'input * xkb_layout fr'
# Test that Print+q now sends hi, as the French AZERTY layout is the new
# "first configured layout" that `--to-code` should respect |
|
@kennylevinsen what do you think of this approach? It's been working without issues for me so far. |
|
@emersion Any concerns with this approach? |
|
A reasonable rate of poking is if roughly 2 weeks have passed - daily is far too much noise for volunteers who are also busy with their day jobs and other projects. |
sahinf
force-pushed
the
bindsym-tocode-dup-children
branch
from
55bea8e
to
e812139
Compare
|
@kennylevinsen me waiting for review : 👁️👄👁️ |
sahinf
force-pushed
the
bindsym-tocode-dup-children
branch
from
e812139
to
7ded6e4
Compare
|
I haven't run into any crashes using this. Any chance we can merge it? |
This modifies `get_active_binding` to treat bindsym --to-codes separately: per each keysym `i` in `binding->keys`, look through the list of matching keycodes in `binding->translations[i]`. Another solution is to take the cartesian product of all syms and make a binding per each product. This makes retranslation more difficult though because the dups from the old layout have to be cleared out before translating to the new `xkb_layout`. Whether by retaining a parent binding, searching through all bindings for matching `binding->command`, or some other ref count structure, that would introduce more complexity than modifying get_active binding to account for dups. Notice this requires no changes to the existing retranslation logic.
sahinf
force-pushed
the
bindsym-tocode-dup-children
branch
from
7ded6e4
to
4d0d553
Compare
|
@emersion Any chance we can get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies
get_active_bindingto treat bindsym --to-codes separately: per each keysymiinbinding->keys, look through the list of matching keycodes inbinding->translations[i].Another solution is to take the cartesian product of all syms and make a binding per each product. This makes retranslation more difficult though because the dups from the old layout have to be cleared out before translating to the new
xkb_layout. Whether by retaining a parent binding, searching through all bindings for matchingbinding->command, or some other ref count structure, that would introduce more complexity than modifying get_active binding to account for dups. Notice this requires no changes to the existing retranslation logic.