Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wechat qrcode fix #45

Merged
merged 13 commits into from
Jan 12, 2024
Merged

Wechat qrcode fix #45

merged 13 commits into from
Jan 12, 2024

Conversation

wresch
Copy link
Contributor

@wresch wresch commented Jan 11, 2024

Thanks for mainting this usefule package. I compile opencv (https://cran.r-project.org/web/packages/opencv/index.html) against ROpenCVLite-installed OpenCV which worked great until recently. In October opencv started wrapping the wechat_qrcode OpenCV module (ropensci/opencv@b66c8b0) which is not included in ROpenCVLite's build resulting in

qrdetect.cpp:5:10: fatal error: opencv2/wechat_qrcode.hpp: No such file or directory
    5 | #include <opencv2/wechat_qrcode.hpp>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~

This is a minimal pull request to add that module and also to generate the opencv pkgconfig files.

@sjmgarnier sjmgarnier changed the base branch from master to develop January 12, 2024 10:21
@sjmgarnier
Copy link
Member

@wresch Thanks for the PR. I am merging it in the develop branch for now until I have more time to multi-platform run compilation tests.

@sjmgarnier sjmgarnier merged commit 2c7f17f into swarm-lab:develop Jan 12, 2024
7 checks passed
@sjmgarnier
Copy link
Member

@wresch FYI, on CRAN now. Thanks!

@wresch
Copy link
Contributor Author

wresch commented Jan 22, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants