Skip to content

Commit

Permalink
Fix CRAN comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
sjmgarnier committed Jul 20, 2023
1 parent c9a3973 commit a5d4e91
Show file tree
Hide file tree
Showing 8 changed files with 37 additions and 21 deletions.
14 changes: 9 additions & 5 deletions R/opencv.R
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
#' @author Simon Garnier, \email{garnier@@njit.edu}
#'
#' @examples
#' defaultOpenCVPath()
#' \dontrun{
#' defaultOpenCVPath()
#' }
#'
#' @export
defaultOpenCVPath <- function() {
Expand Down Expand Up @@ -385,10 +387,12 @@ opencvVersion <- function() {
#' @author Simon Garnier, \email{garnier@@njit.edu}
#'
#' @examples
#' if (isOpenCVInstalled()) {
#' opencvConfig()
#' opencvConfig(output = "cflags")
#' opencvConfig(arch = R.version$arch)
#' \dontrun{
#' if (isOpenCVInstalled()) {
#' opencvConfig()
#' opencvConfig(output = "cflags")
#' opencvConfig(arch = R.version$arch)
#' }
#' }
#'
#' @export
Expand Down
8 changes: 7 additions & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,10 @@ There are currently no downstream dependencies for this package.

## CRAN team comments

N/A.
* Version jumps in minor (submitted: 4.80.0, existing: 4.70.0)

This is normal. The package version follows that of OpenCV.

* Package CITATION file contains call(s) to old-style citEntry(). Please use bibentry() instead.

Fixed.
2 changes: 1 addition & 1 deletion docs/pkgdown.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ pkgdown_sha: ~
articles:
install: install.html
usage: usage.html
last_built: 2023-07-20T07:15Z
last_built: 2023-07-20T12:10Z
urls:
reference: https://swarm-lab.github.io/ROpenCVLite/reference
article: https://swarm-lab.github.io/ROpenCVLite/articles
Expand Down
5 changes: 3 additions & 2 deletions docs/reference/defaultOpenCVPath.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 6 additions & 5 deletions docs/reference/opencvConfig.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions inst/CITATION
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ citHeader("To cite ROpenCVLite in publications use:")
year <- sub("-.*", "", meta$Date)
note <- sprintf("R package version %s", meta$Version)

citEntry(
entry = "Manual",
bibentry(
bibtype = "Manual",
title = "{ROpenCVLite} - Helper package for installing OpenCV with R",
author = "Simon Garnier and John Muschelli",
journal = "",
Expand Down
4 changes: 3 additions & 1 deletion man/defaultOpenCVPath.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 6 additions & 4 deletions man/opencvConfig.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit a5d4e91

Please sign in to comment.