Fix typos #850
Merged
Fix typos #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byorgey
approved these changes
Nov 11, 2022
| @@ -536,7 +536,7 @@ startingDevices = Set.fromList . map snd . E.elems . view installedDevices . ins | |||
| startingInventory :: Scenario -> Map Entity Int | |||
| startingInventory = Map.fromList . map swap . E.elems . view robotInventory . instantiateRobot 0 . head . view scenarioRobots | |||
|
|
|||
| -- | Ignore utility entites that are just used for tutorials and challenges. | |||
| -- | Ignore utility entities that are just used for tutorials and challenges. | |||
| ignoredEntites :: Set Text | |||
There was a problem hiding this comment.
Yeah, ignoredEntites is definitely supposed to be ignoredEntities. We would welcome a PR fixing that too!
|
@bwignall, congrats on having your first PR accepted to Swarm! We appreciate the contribution and we're really glad to welcome you as part of the community. In a minute we will send you an invite to the repo (see https://github.com/swarm-game/swarm/blob/main/CONTRIBUTING.md#i-have-push-access-to-the-swarm-repository-now-what ). If you use IRC, feel free to also join the I would also particularly point you to #829 , if that's something you might be interested to participate in! |
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2022
This was suggested in #850 as a typo. `git grep ignoredEntites` now comes back empty and `stack build` compiles cleanly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes should be non-semantic (e.g., only in code comments).
I am brand new to Swarm, apologies if I misinterpreted something (thinking particularly of "entites") as a typo that is not; happy to revert those if so.
Code itself is not changed, so
ignoredEntitesremains, though I expect it should beignoredEntities(with an "i" added).