fix local paths for new scenario scripts #833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kostmo I've been trying out the new scenario and it seems really fun (aside from the fact that it doesn't work without fixing the paths of course). But I've got some additional feedback that I think will improve it. Rather than pushing a bunch of individual fixes, I think it probably makes more sense to revert the commit that added the new scenario, and then open a traditional PR where we can discuss and improve the scenario as a whole. Let me know if you want to do that or if you'd like me to. |
|
Agreed: #834 for reversion |
|
New PR: #835 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.