Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logging intangible #2049

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Make logging intangible #2049

merged 3 commits into from
Jul 17, 2024

Conversation

noahyor
Copy link
Member

@noahyor noahyor commented Jul 15, 2024

Closes #1991.

@noahyor noahyor requested review from byorgey and xsebek July 15, 2024 18:41
@@ -30,7 +31,7 @@ robots:
- logger
- clock
program: |
log "I shall sleep"; wait 1; log "I have awoken"
log "I shall sleep"; wait 2; log "I have awoken"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this test still make sense, now that we wait for two ticks and newly in solution for one? 🤔

@noahyor noahyor added the merge me Trigger the merge process of the Pull request. label Jul 17, 2024
@mergify mergify bot merged commit e16283a into main Jul 17, 2024
14 checks passed
@mergify mergify bot deleted the noahyor/intangible-log branch July 17, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider making the log command intangible
3 participants