Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove grid overlay truncation behavior #1995

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Jun 27, 2024

In the implementation of #1826, I decided to preserve the old truncating behavior as the default. But after some consideration, there's no real use case for the old behavior, so let's take it out to simplify the code.

@kostmo kostmo requested a review from byorgey June 27, 2024 01:21
@kostmo kostmo marked this pull request as ready for review June 27, 2024 01:21
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am always in favor of PRs that delete more lines than they add. 😁

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Jun 27, 2024
@mergify mergify bot merged commit d9382ad into main Jun 27, 2024
14 checks passed
@mergify mergify bot deleted the feature/no-grid-truncation branch June 27, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants