Update FromJSON TickNumber instance to match ToJSON instance
#1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byorgey
changed the title
FromJSON TickNumber instance to match ToJSON instance
kostmo
approved these changes
May 27, 2024
src/swarm-engine/Swarm/Game/Tick.hs
Outdated
|
|
||
| instance ToJSON TickNumber where | ||
| toJSON = A.genericToJSON (A.defaultOptions {A.unwrapUnaryRecords = True}) | ||
|
|
||
| instance FromJSON TickNumber where | ||
| parseJSON = A.genericParseJSON (A.defaultOptions {A.unwrapUnaryRecords = True}) |
There was a problem hiding this comment.
Maybe want to define (A.defaultOptions {A.unwrapUnaryRecords = True}) at the toplevel and share it?
There was a problem hiding this comment.
Sure, good idea. Do you think we might want to use it in other modules as well (i.e. should we put it in some kind of util module, or just define it right here)?
There was a problem hiding this comment.
Util module sounds good. Perhaps name it optionsUnwrapUnary.
byorgey
force-pushed
the
push-tuyllxzozpuv
branch
from
f3cb639
to
5914060
Compare
Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1868.