Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

biomes #1815

Merged
merged 2 commits into from
May 3, 2024
Merged

biomes #1815

merged 2 commits into from
May 3, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented May 2, 2024 •
edited
Loading

Closes #1642

@restyled-io restyled-io bot mentioned this pull request May 2, 2024
Closed
@kostmo kostmo requested a review from byorgey May 3, 2024 00:41
@kostmo kostmo marked this pull request as ready for review May 3, 2024 00:41
@kostmo kostmo mentioned this pull request May 3, 2024
Merged
byorgey
byorgey approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a couple minor things to fix.

Might be interesting to incorporate this into standard entities in the classic open world (but perhaps only once we address #742 ). Would make farming a bit more interesting!

data/scenarios/Testing/1642-biomes.yaml Outdated Show resolved Hide resolved
data/schema/entity.json Outdated Show resolved Hide resolved
@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label May 3, 2024
@mergify mergify bot merged commit db920df into main May 3, 2024
11 checks passed
@mergify mergify bot deleted the feature/biomes branch May 3, 2024 11:31
@kostmo kostmo added the CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Whitelist biomes for growable entities
2 participants
@kostmo @byorgey