Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor to remove swarm-tournament dep from swarm-integration #1809

Merged
merged 6 commits into from
Apr 29, 2024

Commits on Apr 28, 2024

  1. refactor to remove swarm-tournament dep from swarm-integration

    The only reason the `swarm-integration` test had `swarm-tournament` as
    a dependency was because of a few validation functions in
    `Swarm.Web.Tournament.Validate`.  However, this seemed to me like a
    strange place for those validation functions to live, since they had
    nothing to do with running a tournament in particular, and it meant
    that running the integration tests required having postgresql
    installed even though no databases are used in the integration tests
    at all.
    
    This PR moves those validation functions to two more generic places:
    the first function to extract text from a sequence of log messages now
    lives in `Swarm.Log`, and the other two functions to check for bad
    errors and run a `GameState` to completion now live in a new module
    `Swarm.Game.Step.Validate`.
    byorgey committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    d09b80f View commit details
    Browse the repository at this point in the history
  2. Restyled by fourmolu (#1810)

    Co-authored-by: Restyled.io <[email protected]>
    restyled-io[bot] and restyled-commits authored Apr 28, 2024
    Configuration menu
    Copy the full SHA
    d6069ba View commit details
    Browse the repository at this point in the history
  3. run cabal-gild

    byorgey committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    b1ccf61 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'refactor/integration-no-tournament-dep' of github.com:s…

    …warm-game/swarm into refactor/integration-no-tournament-dep
    byorgey committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    7647ae1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    028f3ad View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Configuration menu
    Copy the full SHA
    aaf6805 View commit details
    Browse the repository at this point in the history