Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor hierarchy of state inputs #1799

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Refactor hierarchy of state inputs #1799

merged 1 commit into from
Apr 10, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Apr 10, 2024 •
edited
Loading

Towards #1797

Combines TerrainEntityMaps and WorldMap into a single record, ScenarioInputs.

Establishes a Matroska-style arrangement of records to represent various scopes of state, eliminating several redundant fields.

@kostmo kostmo mentioned this pull request Apr 10, 2024
Merged
1 task
@kostmo kostmo added the Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. label Apr 10, 2024
@kostmo kostmo requested a review from byorgey April 10, 2024 04:28
@kostmo kostmo marked this pull request as ready for review April 10, 2024 04:28
@kostmo kostmo changed the title Refactor hierarchy of inputs Refactor hierarchy of state inputs Apr 10, 2024
byorgey
byorgey approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, seems like a nice change.

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Apr 10, 2024
@mergify mergify bot merged commit 3263056 into main Apr 10, 2024
9 checks passed
@mergify mergify bot deleted the refactor/combine-scenario-inputs branch April 10, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostmo @byorgey