Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

direction rendering #1793

Merged
merged 2 commits into from
Mar 16, 2024
Merged

direction rendering #1793

merged 2 commits into from
Mar 16, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Mar 14, 2024 •
edited
Loading

Code consolidation.

@kostmo kostmo added the Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. label Mar 14, 2024
@kostmo kostmo requested a review from byorgey March 16, 2024 02:11
@kostmo kostmo marked this pull request as ready for review March 16, 2024 02:11
byorgey
byorgey approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kostmo , are there any other outstanding PRs ready for review that I missed?

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Mar 16, 2024
@mergify mergify bot merged commit 6813c3b into main Mar 16, 2024
9 checks passed
@mergify mergify bot deleted the refactor/direction-rendering branch March 16, 2024 14:30
@kostmo
Copy link
Member Author

kostmo commented Mar 17, 2024

@kostmo , are there any other outstanding PRs ready for review that I missed?

Nope, all in various stages of WIP. Though did you happen to see #1691 that I posted a while ago?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostmo @byorgey