Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix watch wakeup test #1791

Merged
merged 1 commit into from
Mar 15, 2024
Merged

fix watch wakeup test #1791

merged 1 commit into from
Mar 15, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Mar 12, 2024

This improves the test introduced in #1736 in a few ways:

  • Place the system robot's code inline in the program field
    • even though the system bot had been using instant, the run command itself incurs a delay. So this ensures the system robot is ready to monitor the cell immediately
  • System robot uses exclusively Intangible commands in its monitoring loop
    • This allows removal of the instant command.
    • Surveil, which does not appear in any scenario yet, is made Intangible.
  • Remove the initial wait 2 in the player robot's solution.

Tested to ensure that this still exercises the problem that #1736 set out to solve, by commenting out this line (causing the scenario to fail).

currentTickWakeableBots .= currTickWakeable

Demo

scripts/play.sh -i data/scenarios/Testing/1598-detect-entity-change.yaml --autoplay --speed 1

@kostmo kostmo requested a review from byorgey March 13, 2024 04:17
@kostmo kostmo marked this pull request as ready for review March 13, 2024 04:19
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Mar 15, 2024
@mergify mergify bot merged commit 02eecba into main Mar 15, 2024
11 checks passed
@mergify mergify bot deleted the refactor/better-watch-wakeup-test branch March 15, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants