-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extensible terrain #1775
Merged
Merged
extensible terrain #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostmo
force-pushed
the
feature/extensible-terrain
branch
4 times, most recently
from
February 22, 2024 03:05
438c399
to
644ea72
Compare
kostmo
force-pushed
the
feature/extensible-terrain
branch
3 times, most recently
from
February 23, 2024 01:04
505d6c1
to
5c3dc2d
Compare
kostmo
force-pushed
the
feature/extensible-terrain
branch
from
February 23, 2024 01:36
5c3dc2d
to
71c837c
Compare
kostmo
force-pushed
the
feature/extensible-terrain
branch
from
February 23, 2024 02:16
71c837c
to
f92d840
Compare
Cool! Working through reviewing this slowly but surely. |
byorgey
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open
byorgey
added
the
CHANGELOG
Once merged, this PR should be highlighted in the changelog for the next release.
label
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1641
The
data/terrain.yaml
file is now the authoritative source of terrains, thoughBlankT
is still a hard-coded special case.I have not changed the underlying integer representation of terrain in the world function, which means that the
terrainIndexByName
Map in theTerrainMap
record is needed for translating betweenInt
andTerrainType
.Demo
Changes
integrateScenarioEntities
that combined theEntityMap
stored in theScenario
record with the global entity map. However, the global entity map is accessible at parse time of theScenario
, so we do the combining there and only ever store the combined map in theScenario
record.