Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beekeeping scenario #1599

Merged
merged 6 commits into from
Nov 28, 2023
Merged

beekeeping scenario #1599

merged 6 commits into from
Nov 28, 2023

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Oct 23, 2023

Builds upon #1579

Requires player to constuct beehives to attract bees and make honey, which is then brewed as mead.

Demo

scripts/play.sh -i scenarios/Challenges/Ranching/beekeeping.yaml --autoplay

image

Map:
map

References

Mead hall inspiration: https://cartographyassets.com/assets/13507/the-mead-hall-of-the-clan-ulfgar-50-x-50/

Mead-Hal-v1-No-Light-or-Shadow-with-grid-copy-scaled

@kostmo kostmo force-pushed the scenario/beekeeping branch 2 times, most recently from 35580bd to 59d5bce Compare October 29, 2023 05:26
Base automatically changed from feature/structure-previews to main November 8, 2023 18:43
@kostmo kostmo added CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. T-Challenges Involves the challenge scenarios - shorter games with objectives. labels Nov 9, 2023
@kostmo kostmo force-pushed the scenario/beekeeping branch 4 times, most recently from 9e55149 to dfa2825 Compare November 14, 2023 22:25
@kostmo kostmo marked this pull request as ready for review November 23, 2023 08:48
@kostmo kostmo requested a review from byorgey November 23, 2023 08:48
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this, but there's something strange going on with the bees. I constructed one beehive and a bee spawned and started making honeycombs. Great, so I went to make another couple beehives (as the goal text hinted I should) but at some point after making them I realized one of them had no bee:

missing-bee

Are the bees supposed to die sometimes?

Anyways, I collected up the materials for that beehive and tried rebuilding it, but still no bee. Eventually the bee in the central beehive disappeared too, and there was only one bee left in the rightmost beehive. After that, no matter how many times I tore down and rebuilt the other beehives I could only ever get one bee. One time I think I observed that the moment I built the central beehive, a new bee spawned in the righmost beehive, and the bee which had been at that rightmost beehive and was out gathering nectar immediately disappeared.

@kostmo
Copy link
Member Author

kostmo commented Nov 23, 2023

Are the bees supposed to die sometimes

Colony Collapse Disorder?

No, actually I think the logic associating a bee with a hive is fragile. Bees should disappear if a hive is deconstructed. Will fix.

@kostmo
Copy link
Member Author

kostmo commented Nov 26, 2023

I believe the disappearing bee logic is fixed now.

Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! 🐝 🍯

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Nov 28, 2023
@mergify mergify bot merged commit e03251c into main Nov 28, 2023
10 checks passed
@mergify mergify bot deleted the scenario/beekeeping branch November 28, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. merge me Trigger the merge process of the Pull request. T-Challenges Involves the challenge scenarios - shorter games with objectives.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants