Restore the "classic world" background for friend challenge
#1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken by #1376. Any challenge which did *not* specify a `default` field would have had the classic world as an implicit background, but I failed to add the proper `dsl` field to specify it.
xsebek
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Before #1376, these scenarios did not have default specified:
git checkout 888ee44~1
cd data/scenarios
find -name '*.yaml' -exec echo -n {} " " \; -exec yq '.world.default' {} \; | grep ' null'
# ./classic.yaml null
# ./Challenges/gopher.yaml null
# ./Challenges/friend.yaml null
# ./creative.yaml null
# ./Tutorials/world101.yaml null
# ./Tutorials/backstory.yaml null
# ./Tutorials/farming.yaml null
# ./Speedruns/forester.yaml null
# ./Speedruns/curry.yaml null
# ./Speedruns/mithril.yaml nullIt looks like only gopher and friend are missing a DSL now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken by #1376. Any challenge which did not specify a
defaultfield would have had the classic world as an implicit background, but in this case I failed to add the properdslfield to specify it. I don't think there are any other such challenge scenarios, although to be really sure we would have to identify all the scenarios did not specify adefaultfield before #1376 was merged and ensure that each of them now has an appropriatedslfield.Before:
After: