robot wave scenario #1556
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| def go = | ||
| move; | ||
| go; | ||
| end; | ||
|
|
||
| def start = | ||
| turn right; | ||
| wait 5; | ||
| try { | ||
| go; | ||
| } {}; | ||
| grab; | ||
| end; | ||
|
|
||
| start; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| def doN = \n. \f. if (n > 0) {f; doN (n - 1) f} {}; end; | ||
|
|
||
| def crossPath = | ||
| doN 6 move; | ||
| turn back; | ||
| wait 5; | ||
| end; | ||
|
|
||
| def go = | ||
| crossPath; | ||
| go; | ||
| end; | ||
|
|
||
| def start = | ||
| pos <- whereami; | ||
| wait $ fst pos; | ||
| go; | ||
| end; | ||
|
|
||
| start; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| version: 1 | ||
| name: Wave | ||
| author: Karl Ostmo | ||
| description: | | ||
| Ride the wave | ||
| creative: false | ||
| objectives: | ||
| - goal: | ||
| - | | ||
| Grab the `bitcoin`{=entity} at the east end of the path. | ||
| Don't let the patrolling robots catch you! | ||
| prerequisite: | ||
| not: got_caught | ||
| condition: | | ||
| as base {has "bitcoin"}; | ||
| - id: got_caught | ||
| teaser: Got caught | ||
| optional: true | ||
| hidden: true | ||
| goal: | ||
| - | | ||
| The robots caught you! | ||
| condition: | | ||
| as base {x <- meet; return $ case x (\_. false) (\_. true)}; | ||
| robots: | ||
| - name: base | ||
| dir: [0, 1] | ||
| devices: | ||
| - branch predictor | ||
| - comparator | ||
| - dictionary | ||
| - grabber | ||
| - hourglass | ||
kostmo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - lambda | ||
| - logger | ||
| - net | ||
| - scanner | ||
| - strange loop | ||
| - treads | ||
| - name: wavebot | ||
| system: true | ||
| dir: [0, 1] | ||
| display: | ||
| invisible: false | ||
| attr: 'plant' | ||
| program: | | ||
| run "scenarios/Challenges/_wave/wavebot.sw" | ||
kostmo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| solution: | | ||
| run "scenarios/Challenges/_wave/solution.sw" | ||
| entities: [] | ||
| known: [wavy water, water, bitcoin] | ||
| world: | ||
| dsl: | | ||
| overlay | ||
| [ {dirt, water} | ||
| , if x % 7 + y % 5 == 0 then {dirt, wavy water} else {blank} | ||
|
There was a problem hiding this comment. Nice, I like the repeating pattern, it looks like old school games. 🎮 |
||
| ] | ||
| upperleft: [-3, 6] | ||
| offset: false | ||
| palette: | ||
| 'B': [grass, erase, base] | ||
| 'w': [grass, erase, wavebot] | ||
| 'x': [dirt, water] | ||
| 'z': [grass, bitcoin] | ||
| '.': [grass, erase] | ||
| map: | | ||
| xxxxxx..................................................................................................................................................................................................................................................xxxxxx | ||
| xxx........................................................................................................................................................................................................................................................xxx | ||
| x............................................................................................................................................................................................................................................................x | ||
| B............................................................................................................................................................................................................................................................z | ||
| x............................................................................................................................................................................................................................................................x | ||
| xxx........................................................................................................................................................................................................................................................xxx | ||
| xxxxxxwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwxxxxxx | ||
|
|
||
|
There was a problem hiding this comment. Maybe this could be a bit shorter? Though it does work well as a performance test. 😅 |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this is needlessly slow because we do not inline it.
I also tried replacingBut do not do this, I measured it andwaitwithturn forward.waitis better!Subjectively, the simulation seemed to keep playing better without lag on my computer once inlined.
EDIT: I will try to rebuild with profiling enabled and see if the difference is measurable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just following a blog post about profiling with cabal, I can see some difference in the graphs:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xsebek Great work looking at performance, memory profiling, etc.! We haven't paid much attention to it so far but I'm sure there is tons of low-hanging fruit to improve performance.
I'm not sure inlining things in scenario programs is the right way to go, though. Ideally we should be able to encourage nice, modular code and work hard to make that nice, abstracted, modular code run fast.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@byorgey it’s definitely not ideal to do it manually, thats why I made an issue to do it automatically. 🙂
@kostmo I would suggest inlining and adding a TODO linking the inline issue, but up to you.