Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print REPL errors inline and get rid of error popup #1487

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Print REPL errors inline and get rid of error popup #1487

merged 4 commits into from
Sep 5, 2023

Conversation

byorgey
Copy link
Member

@byorgey byorgey commented Sep 4, 2023 •
edited
Loading

Closes #1461. Errors which used to be displayed in a pop-up window (parse errors, type errors) are now displayed inline in the REPL window instead.

  • Get rid of the pop-up error dialog
  • Also fix a bug introduced in Improvements to scrolling #1481 where the REPL history would not be properly cleared when first starting a new scenario, because the old cache was still being used

@byorgey
get rid of error dialog and put error messages inline in REPL
107fc8e
@byorgey
update tutorial to reflect new location of error messages
79112c7
@byorgey
update Haddock
04e12ac
@byorgey
invalidate cache when starting new game
d5e213e 
This fixes an issue introduced in #1481, where the old REPL history
would still be visible when starting a new scenario until entering a
command for the first time.

Incidentally, this also fixes the issue where the previous world would be
sometimes briefly visible before showing the new world upon starting a
new scenario.
xsebek
xsebek approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@xsebek xsebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 It might be worth including in CHANGELOG as it affects the player experience.

@byorgey byorgey added CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. merge me Trigger the merge process of the Pull request. labels Sep 4, 2023
@mergify mergify bot merged commit 1024d2d into main Sep 5, 2023
10 checks passed
@mergify mergify bot deleted the feature/inline-errors branch September 5, 2023 03:44
@byorgey byorgey mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xsebek xsebek xsebek approved these changes

@kostmo kostmo Awaiting requested review from kostmo

Assignees
No one assigned
Labels
CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of error popup and show errors inline in REPL
2 participants
@byorgey @xsebek