Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalise versions for comparison #1448

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Normalise versions for comparison #1448

merged 2 commits into from
Aug 23, 2023

Conversation

xsebek
Copy link
Member

@xsebek xsebek commented Aug 23, 2023

  • make sure that 0.4 and 0.4.0.0 are the same

This fixes the issue worked around by 5c509d2 for future releases.

@xsebek xsebek requested a review from byorgey August 23, 2023 08:09
@xsebek xsebek mentioned this pull request Aug 23, 2023
Merged
byorgey
byorgey approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xsebek xsebek added the merge me Trigger the merge process of the Pull request. label Aug 23, 2023
@mergify mergify bot merged commit 8a17433 into main Aug 23, 2023
10 checks passed
@mergify mergify bot deleted the normalize-version branch August 23, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xsebek @byorgey