-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more markup to tutorial objectives prose #1412
Conversation
b0180bb
to
1faee74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Just so you know putting anything in curly braces will opt out of parsing, you could even do:
Water the `flower`{=Hziulquoigmnzhah}s please.
and it would do the same thing - which is nothing, because I did not implement any extra logic for raw inlines, beyond highlighting them in descriptions.
It would be cool to have differentiated color coding for the various annotations |
@@ -38,7 +38,7 @@ objectives: | |||
evaluated until needed. In this case, we want to make sure | |||
that only the correct branch is evaluated. To write a value | |||
of type, say, `{int}`{=type}, we just surround a value of type `int`{=type} | |||
in curly braces, like `{3}`. This is why arguments to `build` | |||
in curly braces, like `{3}`{=snippet}. This is why arguments to `build` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why snippet
? My understanding is that plain backticks are for anything which is a valid swarm-lang expression. There are a bunch of other similar places where I think you added snippet
unnecessarily. We defintely don't want to use it if we don't have to since snippets
are not checked whereas plain backticks are parsed and typechecked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I failed to read the docs 👓 .
@kostmo that is definitely the intention. 🙂 Right now, any garbage in curly braces will stop parsing and the conventions are not enforced (also not set in stone yet). Once we have the nice |
1faee74
to
21ab251
Compare
@kostmo it seems you were quite thorough, I only found a few tidbits. 👍 |
68a1d77
to
a516597
Compare
Closes #1411