Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic re-orientation via portal #1390

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Automatic re-orientation via portal #1390

merged 4 commits into from
Jul 24, 2023

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Jul 21, 2023 •
edited
Loading

Closes #1379

Related: #950

Also moves "directions" types/logic into its own module.

Demo

scripts/play.sh --scenario data/scenarios/Testing/1379-single-world-portal-reorientation.yaml --autoplay

@kostmo kostmo added Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. L-Commands Built-in commands (e.g. move, try, if, ...) in the Swarm language. G-Scenarios An issue having to do with scenario design, the way scenarios are described and loaded, etc. labels Jul 22, 2023
@kostmo kostmo marked this pull request as ready for review July 22, 2023 20:42
@kostmo kostmo requested a review from byorgey July 22, 2023 20:42
@kostmo kostmo changed the title [WIP] Automatic re-orientation via portal Automatic re-orientation via portal Jul 22, 2023
byorgey
byorgey approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few simple things to address before merging, I think.

src/Swarm/Language/Directions.hs Outdated Show resolved Hide resolved
src/Swarm/Language/Directions.hs Outdated Show resolved Hide resolved
src/Swarm/Language/Directions.hs Outdated Show resolved Hide resolved
data/scenarios/Testing/1379-single-world-portal-reorientation.yaml Show resolved Hide resolved
src/Swarm/Game/Scenario/Topography/Navigation/Portal.hs Show resolved Hide resolved
@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Jul 24, 2023
@mergify mergify bot merged commit b7cdff0 into main Jul 24, 2023
9 checks passed
@mergify mergify bot deleted the feature/portal-reorient branch July 24, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
G-Scenarios An issue having to do with scenario design, the way scenarios are described and loaded, etc. L-Commands Built-in commands (e.g. move, try, if, ...) in the Swarm language. merge me Trigger the merge process of the Pull request. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatically re-orient robot when passing through portals
2 participants
@kostmo @byorgey