Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support proper mapping of the byte array #3955

Closed
wants to merge 12 commits into from

Conversation

reta
Copy link
Contributor

@reta reta commented May 13, 2021

An attempt to properly map byte[] to the ByteArraySchema or BinarySchema depending on the format specified (if any). The idea here is to introduce the support in PrimitiveType of types which could be mapped to multiple schemas, depending on the format, with the first one being the default in case format is omitted. Closes #3944 and #3511.

Specification snippets generated:

        bytes:
          type: string
          format: byte
        binary:
          type: string
          format: binary

@webron would really appreciate the feedback if this change make sense, test cases are include, thanks a lot.

@reta
Copy link
Contributor Author

reta commented May 24, 2021

My apologies @webron , any interest or feedback on this pull request would be much appreciated, thank you :-)

@martin-tarjanyi
Copy link
Contributor

@reta, I created a pull request for your branch to add support for base64 encoded string examples for byte and binary format. Please, consider including it. Thanks.

@reta
Copy link
Contributor Author

reta commented Jul 4, 2021

thanks @martin-tarjanyi , included, hopefully we could get some attention from the team

@reta
Copy link
Contributor Author

reta commented Aug 17, 2021

@frantuma @HugoMario guys, mind please taking a look? thank you!

@reta
Copy link
Contributor Author

reta commented Apr 2, 2022

@HugoMario @frantuma hey guys, any chance someone could look at it? thank you!

@HugoMario
Copy link
Contributor

hey @reta , sure. I'll take a time this week to check your PR

@reta
Copy link
Contributor Author

reta commented Jun 2, 2022

hey @HugoMario , any chances to have a pair of eyes on it? :-) Thank you!

@RInverid
Copy link

@HugoMario did you have a chance to look at this PR yet?

@HugoMario
Copy link
Contributor

Hey @reta
Is the jetty version update related to changs in byte array?
BTW, PR looks good to me. I'll sync up again with my team to check this again.

Sorry for so much delay

@reta
Copy link
Contributor Author

reta commented Apr 2, 2023

Hey @HugoMario !

Hey @reta Is the jetty version update related to changs in byte array?

No, it shouldn't be (AFAIK)

BTW, PR looks good to me. I'll sync up again with my team to check this again.

Thanks a mill, really appreciate it!

@frantuma frantuma self-assigned this Apr 9, 2024
@frantuma
Copy link
Member

Thanks all for your patience, this is included and replaced by #4659

@frantuma frantuma closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default mapping of java byte array
5 participants