-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support proper mapping of the byte array #3955
Conversation
My apologies @webron , any interest or feedback on this pull request would be much appreciated, thank you :-) |
@reta, I created a pull request for your branch to add support for base64 encoded string examples for byte and binary format. Please, consider including it. Thanks. |
Support examples for binary and byte formats
thanks @martin-tarjanyi , included, hopefully we could get some attention from the team |
@frantuma @HugoMario guys, mind please taking a look? thank you! |
d823460
to
4b09b4e
Compare
@HugoMario @frantuma hey guys, any chance someone could look at it? thank you! |
hey @reta , sure. I'll take a time this week to check your PR |
...les/swagger-jaxrs2/src/test/java/io/swagger/v3/jaxrs2/resources/BinaryParameterResource.java
Dismissed
Show dismissed
Hide dismissed
hey @HugoMario , any chances to have a pair of eyes on it? :-) Thank you! |
@HugoMario did you have a chance to look at this PR yet? |
Hey @reta Sorry for so much delay |
Hey @HugoMario !
No, it shouldn't be (AFAIK)
Thanks a mill, really appreciate it! |
Thanks all for your patience, this is included and replaced by #4659 |
An attempt to properly map
byte[]
to theByteArraySchema
orBinarySchema
depending on the format specified (if any). The idea here is to introduce the support inPrimitiveType
of types which could be mapped to multiple schemas, depending on the format, with the first one being the default in case format is omitted. Closes #3944 and #3511.Specification snippets generated:
@webron would really appreciate the feedback if this change make sense, test cases are include, thanks a lot.