#482 - Masks are now rendered #825
Conversation
|
If someone wants to review this, please go ahead! I was going to review it for some time now, but didn't get to it due to time constraints, so I would appreciate if someone else could have a look. At a first glance, it looked quite good. |
Source/Svg.csproj
Outdated
| @@ -144,6 +144,62 @@ Many performance improvements by using SourceGenerators instad of reflection. | |||
| <PropertyGroup Condition="'$(TargetFramework)' != 'net452'"> | |||
| <DefineConstants>$(DefineConstants);USE_SOURCE_GENERATORS</DefineConstants> | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|netstandard2.0|AnyCPU'"> | |||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | |||
There was a problem hiding this comment.
Is this property required for each ?
There was a problem hiding this comment.
I suppose so? That was auto-generated so I'm not 100% sure but please let me know what you think the better approach would be.
|
Regarding disposing bitmaps, I'll have a look into it later. |
|
I think we cannot introduce the unsafe flag, many bigger enterprise projects don't allow to reference assemblies with that flag. New .NET versions have many new safe memory operations. Probably worth looking at them. And for bitmap disposal, you should use |
Ok, that's a fair point. Any details on these new memory operations I could read? |
|
How about using Span ? |
|
I will check source files, but it will take some time because there are many changes... |
| Assert.Greater(equalPercentage, 99); | ||
| } | ||
| } | ||
| } |
|
|
||
| public void SetMask(Bitmap mask) | ||
| { | ||
| _mask = mask; |
There was a problem hiding this comment.
_mask?.Dispose();
_mask = mask;There was a problem hiding this comment.
And dispose _mask in Dispose method.
| return _mask; | ||
| } | ||
|
|
||
| public void DisposeMask() |
There was a problem hiding this comment.
Delete this method.
Use SetMask(null);
| { | ||
| _innerGraphics = graphics; | ||
| _disposable = disposable; | ||
| this.RenderSize = renderSize; |
There was a problem hiding this comment.
remove this.
Please omit this as much as possible.
| return new[] | ||
| { | ||
| rectangle.Location, | ||
| rectangle.Location + rectangle.Size |
There was a problem hiding this comment.
here should consider five points like this, If there are only two points, there will have issue with the bounds when the transform contains rotation
return new[]
{
rectangle.Location,
rectangle.Location + rectangle.Size,
new PointF(rectangle.X,rectangle.Y+rectangle.Height),
new PointF(rectangle.X+rectangle.Width,rectangle.Y)
};There was a problem hiding this comment.
you can verify this by this transform : "matrix(0.51 0.51 -0.51 0.51 776.90 96.03)"
|
@thenkles Sorry for the delay is resolving this PR. Please can you rework and repost this for consideration? |
|
@thenkles Sorry for the delay, please can you update this project for consideration? |
Fixes issue #482
What does this implement/fix? Explain your changes.
Adds support for alpha masks.
Any other comments?
The ImagesAreEqual method in SvgTestHelper has been updated to increase performance and additional parameter has been added: allowedDifference. This is the maximum deviation allowed for each pixel's component, i.e. if allowedDifference is 1, and the expected pixel is RGBA(100, 100, 100, 100), then RGBA(101, 101, 101, 101), RGBA(99, 99, 99, 99), etc. will also be accepted. This was required because the results are not always pixel perfect equal when tests are run on different targets.