Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Makefile.staticlibrary #2420

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Add Makefile.staticlibrary #2420

merged 1 commit into from
Jan 22, 2024

Conversation

ffontaine
Copy link
Contributor

Signed-off-by: Fabrice Fontaine [email protected]

#DUKTAPE_SRCDIR = ./src-noline

AR = ar
CC = gcc
Copy link

@c2vi c2vi Jan 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found myself wanting to build a static version of duktape. (using this pull-request and nix: nix build nixpkgs#pkgsStatic.duktape, with the patch applied) and those two lines should be:

AR ?= ar
AR := $(AR)
CC ?= gcc
CC := $(CC)

just like in the Makefile.sharedlibrary on the master branch. So that it uses my x86_64-unknown-linux-musl-gcc from $CC of the Environment instead of just gcc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR but it is opened since 2021 ...

Signed-off-by: Fabrice Fontaine <[email protected]>
@svaarala svaarala merged commit 0bbd6cd into svaarala:master Jan 22, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants