fix: Remove clone-deep dependency in favor of native structuredClone

[askoufis]

Given this package's supported node version is >=18, we can safely use the native structuredClone global instead of clone-deep, removing 5 dependencies in the process. I don't think it behaves any differently to clone-deep on plain objects, so this change shouldn't result in any unexpected config changes, and the tests seem to agree (they all pass).

Let me know if there's a good reason not to do this.

[bebraw]

Thanks a lot. I actually never published 6.0.0 but I figured it was safe to publish since Node 20 is LTS already. I included your change in 6.0.0.

[msev]

Hi,

I have an issue since 6.0.0.

When i run yarn build, i have the following error:

Failed to load '/.config/webpack/prod.config.js' config
[webpack-cli] DOMException [DataCloneError]: async function terserMinify(input, sourceMap, minimizerOptions, extractComments) {
  /**
   * @param {any} valu...<omitted>...
} could not be cloned.
    at new DOMException (node:internal/per_context/domexception:53:5)
    at _joinArrays (/node_modules/webpack-merge/dist/join-arrays.js:64:20)
    at /node_modules/webpack-merge/dist/merge-with.js:32:17
    at Array.forEach (<anonymous>)
    at mergeTo (/node_modules/webpack-merge/dist/merge-with.js:31:10)
    at /node_modules/webpack-merge/dist/merge-with.js:23:15
    at Array.forEach (<anonymous>)
    at mergeWith (/node_modules/webpack-merge/dist/merge-with.js:22:10)
    at mergeWithOptions (/node_modules/webpack-merge/dist/index.js:83:41)
    at merge (/node_modules/webpack-merge/dist/index.js:45:35)

Here's my webpack configuration:

const path = require('path');
const { merge } = require('webpack-merge');
const TerserPlugin = require('terser-webpack-plugin');

const commonConfig = require(path.resolve('./.config/webpack/common.config.js'));
const customConfig = require(path.resolve('./webpack.custom.config.js'));

module.exports = merge(commonConfig, customConfig, {
  mode: 'production',
  devtool: false,
  stats: {
    assets: true,
    assetsSpace: 100,
    entrypoints: true,
    modules: false
  },
  optimization: {
    minimize: true,
    minimizer: [
      new TerserPlugin({
        terserOptions: {
          format: {
            comments: false
          }
        },
        extractComments: false,
        parallel: true
      })
    ],
    splitChunks: {
      minSize: 0,
      cacheGroups: {
        defaultVendors: false,
        vendors: {
          test: /[\\/]node_modules[\\/]/,
          chunks: 'all',
          name(module, chunks, cacheGroupKey) {
            const allChunksNames = chunks.map((item) => item.name).join('@');
            return `${cacheGroupKey}@${allChunksNames}`;
          }
        }
      }
    }
  }
});

[bebraw]

@msev Thanks for the heads up. I reverted the change so now it's using clone-deep again. I also added a note that it shouldn't be removed.

I imagine there's some subtle difference between structuredClone and clone-deep and there was some structure in your configuration structuredClone wasn't able to handle.

The fix is included in 6.0.1.

[msev]

Thanks for the quick fix @bebraw!

Sorry to have spoiled the party 😅

[bebraw]

No worries, it was something the test suite didn't catch.