-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Support for Msg91 phone provider #989
Conversation
Hey @MeetChaudhari MeetChaudhari, thanks for the contribution! Unfortunately, i don't think we plan to merge this in since the team has decided to go with webhooks in the future for custom sms providers which would be more scalable in terms of maintaining the codebase. However, if you need this feature urgently, we recommend that you fork the codebase to include your changes in it. |
@kangmingtay, I understand and agree with your decision, but the thing is, we do not want to self-host the platform, as such we have a lot of microservices to deal with and as founder, I need a bit of stability in the signup process that's the reason I added this like if it is possible to please help me out I would be very grateful to your team and whenever you guys switch to webhooks I'll do all the necessary changes required for my contribution. Like till you guys implement the webhook solution, it would very helpful for me to get started for me with my pr. |
Hey @MeetChaudhari - thanks for the additional context. it's a tricky balance we need to strike between accepting a lot of PRs now (delaying the webhooks implementation) and commiting to the webhook approach. I understand that |
hey @kiwicopple , actually it's not about the cost it is about the reliability as a textlocal customer I have already purchased a good number of sms credits on their platform the problem is sometimes it works flawlessly sometimes it just gives random errors on very frequent basis and this is not an issue with the supabase textlocal integration authored by devkiran, it's from textlocal end. I even had a discussion with devkiran about the issue with textlocal. And just think if I want to get my dream project into production I seriously need to have the reliability of a service. |
Hey @MeetChaudhari, if cost is not an issue and you're looking for reliability, will it be possible to use one of the other providers instead? We also support using Twilio, Messagebird and Vonage on Supabase. Is there a particular reason why you are choosing Msg91 over these other providers? |
Cause that becomes comparatively too expensive for us, as our platform is situated in India for comparison This are rates for sending one message in India in USD. (All prices are taken from their respective brand sites.)
so its pretty obvious for us to use Indian providers |
I guess the challenge for us here - how do we know that it's not just the same problem with msg91? From a quick search, there are quite a few SMS providers in India. If we keep merging new providers and each of them is buggy, it creates more delays for the Auth team to implement the "right" solution (webhooks). Have you raised a ticket with the textlocal team to help solve any issues? |
Hey @kiwicopple i agree with you, the problem was i tried everything possible even my textlocal logs, i agree did not raise any tickets with textlocal team, but not in case of this integration, i signed up as startup on msg91, i have prior experience with msg91, this company serves for multiple unicorn companies in india and my prior experience is flawless with them, supabase textlocal Integration made me switch to textlocal. And as i signed up as startup which is what i have, i have a contact/ direct support of developer form msg91 to mitigate any issues, like even while making integration i had some doubts which was instantly solved by msg91 team. |
https://www.fonada.com/blog/top-10-bulk-sms-service-providers-in-india/ Check this recent article. For more reference |
@MeetChaudhari We see where you're coming from but we are still hesitant to push forward on this for now because providing top-notch support for this feature could be challenging given the issues we've experienced with sending SMSes from other service providers (TextLocal). For example, it was impossible for our support team to debug issues with TextLocal since there's a requirement for one to own a SIM card from India, which requires one to be a citizen of India. Additionally, if we merge in this PR, it could make it harder to turn down future SMS providers since there may always be a case for another one being more reliable or cost-effective. We also haven't received any other request to add Msg91 as an SMS provider and we don't add integrations based on one-off requests. For example, we keep a list of external OAuth provider requests here and we only accept contributions for those that are deemed as "in-demand" from our community. Our goal is to make gotrue more flexible by introducing features like webhooks, which will allow developers to integrate any third-party software they choose, instead of building a customised solution for every auth flow. One alternative that you can consider here will be to host a fork of GoTrue on providers like Fly, which have a free tier, until we've worked out the webhook implementation. |
Yes i completely understand, but as i have talked with msg91 team personally for your problems, they have responded me this "We can even help their team in testing and resolving any bugs and I can personally be in touch with them for that. And i will take care of documentation and maintenance of the integration till you guys implement the webhook solution with being in direct contact with msg91 team. They will help your team to test out integration perfectly. As mentioned above. MSG91 team provides three channels for support to all their customers -
Specifically for Supabase team, they have agreed to assign a dedicated partner manager which can Hardik Menghani Hardik can help you in all challenges - may it be with regards to tech/business/regulation. No other SMS provider in India can offer you services at such a cost-effective pricing with multi-channel support like what MSG91 is offering. |
Co-authored-by: Stojan Dimitrovski <[email protected]>
Co-authored-by: Stojan Dimitrovski <[email protected]>
Thanks for the work on the PR thus far! Gentle reminder to file a PR to the phone-login section of our documentation with setup instructions and link back to this PR so that we can try to test the integration. It'll also be really helpful in helping other developers figure out how to use the integration. Feel free to reference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is generally good now @MeetChaudhari, @kangmingtay, @J0. I'll try to fix some of the technical comments and merge it.
any update on this? |
@MeetChaudhari I've forked this #1018 and fixed it up. I'll close this PR as it's quite out of date. Do you think it's possible for you to contribute some docs for Msg91 similar to these here: https://supabase.com/docs/guides/auth/phone-login/twilio |
Yes i can do it, actually I was waiting for pr to get merged |
What kind of change does this PR introduce?
This PR adds support for Msg91.com , One of the best highly reliable Indian SMS provider rates even lesser than textlocal.
What is the current behavior?
Actually currently present textlocal integration for Indian audience highly unreliable not from the integration point, its from the textlocal servers and my company is currently developing an huge artist centric platform using supabase during our testing we had lot of issues due to textlocal. So today i have added Msg91 support
Additional context
The implementation is loosely based on textlocal implementation.
And due to Indian Government mandate, the message template, header has to be registered before sending any sms.
Also my implementation takes 3 params
For above this i will add documentation for obtain each of the params