This repository has been archived by the owner on Feb 23, 2021. It is now read-only.
Adding dimensions as an option for thumbnail and list view. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -737,6 +737,7 @@ protected function getFiles($dir) { | |||
| $bigIcon = file_exists("themes/{$this->config['theme']}/img/files/big/$ext.png"); | |||
| $smallIcon = file_exists("themes/{$this->config['theme']}/img/files/small/$ext.png"); | |||
| $thumb = file_exists("$thumbDir/$name"); | |||
| list($width, $height) = $img->getSize(); | |||
There was a problem hiding this comment.
Size is already extracted on line 717:
$size = $img->getSize($file);
There is no need to extract the size twice. This can be avoided by replacing your line 740 with:
if ($type && count($size) >= 2)
list($width, $height) = $size;
|
This seems a very nice addition, can it be Pulled ? |
|
This is a useful addition, would be nice to have it Pulled... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option under Settings->Show that lets you display dimensions for images. If not an image then it shows nothing. Screenshot of it below.