-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nl_NL translations for Plunder expansion #537
Add nl_NL translations for Plunder expansion #537
Conversation
Thanks! Can you install pre-commit and run |
Yeah, can do that. I'll probably do it now, if that seems to not have happened, It'll be there in the evening ^^ |
Seems to have some missing tags now: |
OH |
Okay, I just did a pass over the entire diff and fixed as many typos and unclosed tags as i could find. |
Remember you can run tests locally via You'll also need to recompile the gzs and mark the conflict as resolved. |
Ah yes, forgive me, it's been a while since I've done dev stuff xD |
2ce72f4
to
24795fe
Compare
Okay, I rebased on the latest master, I recompiled the card DB one last time (merged into 24795fe since i was rebasing anyway) and i ran the tests locally. Pytest does not seem to be complaining. A note on marking the conflicts as resolved: I don't have write access to this repo, so i cannot mark conflicts as resolved ^^ |
Replaced by #541 |
Help, I think i just lost my sanity...
In all seriousness, these are all card descriptions and extras as per Dutch cards and manual.
In basically all cases i tried to preserve the order as it is in the en_US translations.