Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Rubocop implementation #448

Merged
merged 61 commits into from
May 1, 2024
Merged

Conversation

bobbrodie
Copy link
Member

@bobbrodie bobbrodie commented Apr 29, 2024

Overview

This is the initial implementation of Rubocop. Most of the commits in this PR are stylistic and will not affect functionality at all.

Approach

I wanted to use caution in my approach here, so in general here are the steps that I followed:

First, understand what the most impactful cops are by count and autocorrect-ability:

bundle exec rubocop --format offenses

Next, choose one that's going to be on almost all files, except specs:

bundle exec rubocop --only Style/FrozenStringLiteralComment

This will give us the changeset, so we review before autocorrecting:

bundle exec rubocop --only Style/FrozenStringLiteralComment -A

Now I'll run the tests:

bundle exec rake test

If everything looks good, then check the changes:

git diff

After reviewing, add files, commit, and push.

@bobbrodie bobbrodie added the Maintenance Chores, dependency updates, etc. label Apr 29, 2024
@bobbrodie bobbrodie added this to the v3.0.0 milestone Apr 29, 2024
@bobbrodie bobbrodie merged commit 7f6319d into sumoheavy:master May 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Chores, dependency updates, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants