Skip to content

Commit

Permalink
Now test pass
Browse files Browse the repository at this point in the history
  • Loading branch information
Sasha Demin committed Jul 25, 2023
1 parent c95010b commit 177221e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/groebner/isgroebner.jl
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function _isgroebner(
monoms::Vector{Vector{M}},
coeffs::Vector{Vector{C}},
params
) where {M, C <: CoeffFF}
) where {M <: Monom, C <: CoeffFF}
basis, pairset, hashtable = initialize_structs(ring, monoms, coeffs, params)
f4_isgroebner!(ring, basis, pairset, hashtable)
end
Expand All @@ -29,7 +29,7 @@ function _isgroebner(
monoms::Vector{Vector{M}},
coeffs::Vector{Vector{C}},
params
) where {M, C <: CoeffQQ}
) where {M <: Monom, C <: CoeffQQ}
buffer = CoefficientBuffer()
basis, pairset, hashtable = initialize_structs(ring, monoms, coeffs, params)
# If an honest computation over the rationals is needed
Expand Down
8 changes: 4 additions & 4 deletions test/regressions.jl
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ end
ord = Groebner.DegRevLex()
gb1 = Groebner.groebner([x, y], ordering=ord)
gb2 = Groebner.groebner([R(0)], ordering=ord)
@test ordering(parent(first(gb1))) === :degrevlex
@test ordering(parent(first(gb2))) === :degrevlex
@test AbstractAlgebra.ordering(parent(first(gb1))) === :degrevlex
@test AbstractAlgebra.ordering(parent(first(gb2))) === :degrevlex
nf1 = Groebner.normalform([x, y], x, ordering=ord)
nf2 = Groebner.normalform([x, y], R(0), ordering=ord)
@test ordering(parent(nf1)) === :degrevlex
@test_broken ordering(parent(nf2)) === :degrevlex
@test AbstractAlgebra.ordering(parent(nf1)) === :degrevlex
@test_broken AbstractAlgebra.ordering(parent(nf2)) === :degrevlex
end

@testset "regression, SI.jl cmp" begin
Expand Down

0 comments on commit 177221e

Please sign in to comment.