-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load background images from journal #741
base: master
Are you sure you want to change the base?
Conversation
Tested and seems good to me; anyone else is welcome to discuss about it |
|
||
from gi.repository import Gtk | ||
from gi.repository import Gdk | ||
from gi.repository import GObject | ||
from gi.repository import GdkPixbuf | ||
|
||
from sugar3 import env | ||
from sugar3 import mime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sugar3.mime imported but not used.
Tested. Looks good :) |
Reviewed;
I'd like to see your commit message grow. Use the first line as summary, then press enter twice before going into detail. |
A deleted comment received by e-mail quoted from the GCI task;
This is a good basis for writing the commit message, though it would be conventional to describe the problem first, then the solution. See Making commits in the guide to contributing. |
GCI Task: https://codein.withgoogle.com/dashboard/task-instances/5616648155299840/
I used datastore.find for add images in the view from the journal, and when the user select a journal image, copy that to "/home/user/.sugar/background.[extension]".
Why? Because sugar remove all images journal directory when it's restarted, and aren't yet created when it is necessary to load them as a background, for that, I copy the selected image to the above mentioned address.