Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Corner Layout #740

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added Corner Layout #740

wants to merge 3 commits into from

Conversation

cvgarciarea
Copy link

@cvgarciarea cvgarciarea changed the title Add a new favorites layout 'CornerLayout' Added Corner Layout Dec 5, 2016
@quozl
Copy link
Contributor

quozl commented Dec 6, 2016

Tested an earlier draft.

Reviewed. Comments;

  • setup does not offset the owner icon by allocation.y, result may be collision,
  • the activity icon is not excluded from child allocation area, result may be collision,
  • CornerLayout.setup is mostly duplicated from ViewLayout.setup, we would prefer calling method instead of copy and paste, as that would reduce the number of code lines to be maintained,
  • might use self._grid for collision detection instead of pixel coordinates,
  • might use RandomLayout as parent class, in similar fashion to how previous layouts inherit from RingLayout.

@rhl-bthr
Copy link

rhl-bthr commented Mar 8, 2018

@cristian99garcia, will you be updating the patch or may I do the same, Thanks

@ghost
Copy link

ghost commented Jan 8, 2019

Hi ! Is there anything that still needs to be done?Both the links on the parent comment are dead.

@rhl-bthr
Copy link

rhl-bthr commented Jan 8, 2019

@mk1299, see review comments for what needs to be done in the patch

@quozl
Copy link
Contributor

quozl commented Jan 9, 2019

Yeah, please everybody in future don't use links that expire.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants