Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: version compat checking in build #1791

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

feat: version compat checking in build #1791

wants to merge 3 commits into from

Conversation

nhtyy
Copy link

@nhtyy nhtyy commented Nov 14, 2024

Version checking the sp1-zkvm crate with the current toolchain to ensure compatibly.

Assumes that major/minor of sp1-zkvm and sp1-build matching implies compat, which would be inline if sp1-zkvm inherits workspace version in the future

edit: closes #1625

Copy link

github-actions bot commented Nov 14, 2024

SP1 Performance Test Results

Branch: n/version-check
Commit: fb8c581
Author: nhtyy

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.18 2.88 0.46 24s
ssz-withdrawals 2757356 17.69 129.21 35.30 1m18s
tendermint 12593597 6.70 273.07 100.79 2m7s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nicer error message when toolchain version and sp1-zkvm versions are incompatible
1 participant