feat: cross compile amd64 Linux binaries with Musl #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SP1 Performance Test Results Branch: gro-9-cross-build-with-musl
|
|
are we going to have to wait till the next release to ship new binaries, or can we just change some files now? |
|
@yuwen01 same as before, I haven't changed the events when the workflow is ran: sp1/.github/workflows/release.yml Lines 5 to 10 in 2d73382 Is it needed? |
erabinov
force-pushed
the
gro-9-cross-build-with-musl
branch
from
9a6265e
to
0ec3fff
Compare
jtguibas
reviewed
Nov 12, 2024
jtguibas
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The seg fault in the related issue seems to be caused by a bug in glibc. The solution would be to use musl instead, since anyways static linking with glibc is discouraged.
In this PR, I modified the release CI to use a docker image called muslrust to cross compile the SP1 CLI amd64 Linux binaries with musl instead of glibc.
Closes #1355