Check that dependencies don't include unmerged commits #3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Created branch: z_pr3237/skitt/dummy-change |
skitt
force-pushed
the
dummy-change
branch
6 times, most recently
from
7cdea92
to
a8314c9
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
|
I see the submariner-io/shipyard#1730 PR is merged. What's the plan for other repos? |
I’m updating this PR to use the merged script; once that’s done I’ll replicate the PR on the other repos. |
skitt
force-pushed
the
dummy-change
branch
2 times, most recently
from
d3a1ca0
to
71724bd
Compare
skitt
requested review from
mkolesnik,
Oats87,
sridhargaddam,
tpantelis,
vthapar,
aswinsuryan,
dfarrell07,
maayanf24 and
yboaron
as code owners
|
Looks like it worked! |
This ensures that the project doesn't end up depending on commits that aren't present in the corresponding branch of the dependency. This is useful to prevent merging with pre-rebase commits from cross-project changes; it also ensures that malicious commits from forks can't end up references in the main projects. Signed-off-by: Stephen Kitt <[email protected]>
|
This PR/issue depends on:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the project doesn't end up depending on commits that aren't present in the corresponding branch of the dependency. This is useful to prevent merging with pre-rebase commits from cross-project changes; it also ensures that malicious commits from forks can't end up references in the main projects.
Depends on submariner-io/shipyard#1739