Refactor CIDR manipulation code from globalnet to cidr module #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr3212/tpantelis/refactor_gn_cidr |
tpantelis
force-pushed
the
refactor_gn_cidr
branch
from
6db5d91
to
f39a8e0
Compare
...for reuse. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
refactor_gn_cidr
branch
from
f39a8e0
to
1c0d40e
Compare
Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
refactor_gn_cidr
branch
from
1c0d40e
to
e8ef513
Compare
vthapar
approved these changes
Sep 8, 2024
vthapar
reviewed
Sep 9, 2024
| binary.BigEndian.PutUint32(netIP, ip) | ||
|
|
||
| return netIP | ||
| return cidr.Allocate(&globalnetInfo.Info) //nolint:wrapcheck // No need to wrap | ||
| } | ||
|
|
||
| func GetValidClusterSize(cidrRange string, clusterSize uint) (uint, error) { |
There was a problem hiding this comment.
This can also move to cidr/cidr.go as this will also get reused in clusersetip. But I can do that as part of my changes to add clustersetip code. I'd rather have this merged first.
There was a problem hiding this comment.
I didn't move this b/c I didn't think we were going to make cluster/allocation size configurable for clustersetip.
aswinsuryan
approved these changes
Sep 9, 2024
|
🤖 Closed branches: [z_pr3212/tpantelis/refactor_gn_cidr] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...for reuse with the clusterset IP functionality.