Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump shipyard and address golangci-lint v1.60.3 errors #3202

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

tpantelis
Copy link
Contributor

@tpantelis tpantelis commented Aug 27, 2024

Specifically, gosec "integer overflow conversion" issues.

Depends on submariner-io/shipyard#1715

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr3202/tpantelis/v1.60.3_linting
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

Specifically, gosec "integer overflow conversion" issues.

Signed-off-by: Tom Pantelis <[email protected]>
Copy link

@tpantelis tpantelis enabled auto-merge (rebase) August 28, 2024 15:04
@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Aug 29, 2024
@tpantelis tpantelis merged commit 699e972 into submariner-io:devel Aug 29, 2024
40 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr3202/tpantelis/v1.60.3_linting]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants