Address TODOs regarding cluster network discovery #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"globalCIDR allocation if no global CIDR is assigned and enabled..." This seems to say that the operator should allocate a global CIDR if not done prior but there has been nor is any plan to do so. Signed-off-by: Tom Pantelis <[email protected]>
As per the TODO: "The other branch of this if will not try to find the globalCIDRs". Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
requested review from
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr3162/tpantelis/net_disc_TODOs |
aswinsuryan
reviewed
Jul 24, 2024
aswinsuryan
approved these changes
Jul 24, 2024
skitt
approved these changes
Jul 25, 2024
|
🤖 Closed branches: [z_pr3162/tpantelis/net_disc_TODOs] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.