Improve calico CNI detection #2769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A K8s cluster can be installed with Calico CNI in multiple ways. It was seen that in some deployments the calico-config map is not created but we can find calico-node cni pods running as daemonSet. This PR enhances the code to look for calico-node pods when the config map is not found. Signed-off-by: Sridhar Gaddam <[email protected]>
sridhargaddam
requested review from
Oats87,
skitt and
tpantelis
as code owners
|
🤖 Created branch: z_pr2769/sridhargaddam/calico-detection |
|
Verified this PR by manually deploying a KIND Calico cluster using the following instructions. |
tpantelis
approved these changes
Aug 28, 2023
|
I'm seeing the following errors in the CI jobs. @tpantelis do we already have some fix for this error? |
|
dfarrell07
approved these changes
Aug 28, 2023
|
🤖 Closed branches: [z_pr2769/sridhargaddam/calico-detection] |
dfarrell07
added
backport
sridhargaddam
added a commit
to sridhargaddam/submariner-website
that referenced
this pull request
Sep 11, 2023
Release notes for PR submariner-io/submariner-operator#2769 Signed-off-by: Sridhar Gaddam <[email protected]>
|
Release note PR: submariner-io/submariner-website#1011 |
skitt
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Sep 12, 2023
Release notes for PR submariner-io/submariner-operator#2769 Signed-off-by: Sridhar Gaddam <[email protected]>
dfarrell07
pushed a commit
to dfarrell07/submariner-website
that referenced
this pull request
Oct 18, 2023
Release notes for PR submariner-io/submariner-operator#2769 Signed-off-by: Sridhar Gaddam <[email protected]>
dfarrell07
pushed a commit
to dfarrell07/submariner-website
that referenced
this pull request
Oct 18, 2023
Release notes for PR submariner-io/submariner-operator#2769 Signed-off-by: Sridhar Gaddam <[email protected]>
dfarrell07
pushed a commit
to dfarrell07/submariner-website
that referenced
this pull request
Oct 19, 2023
Release notes for PR submariner-io/submariner-operator#2769 Signed-off-by: Sridhar Gaddam <[email protected]>
tpantelis
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Oct 22, 2023
Release notes for PR submariner-io/submariner-operator#2769 Signed-off-by: Sridhar Gaddam <[email protected]>
tpantelis
pushed a commit
to tpantelis/submariner-website
that referenced
this pull request
Nov 7, 2023
Release notes for PR submariner-io/submariner-operator#2769 Signed-off-by: Sridhar Gaddam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A K8s cluster can be installed with Calico CNI in multiple ways. It was seen that in some deployments the calico-config map is not created but we can find calico-node cni pods running as daemonSet. This PR enhances the code to look for calico-node pods when the config map is not found.