Load balancer deploy fails if OCP not installed #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Created branch: z_pr2749/tpantelis/fix_load_balancer |
Error: "error retrieving cluster Infrastructure resource: failed to get API group resources: unable to retrieve the complete list of server APIs: config.openshift.io/v1: the server could not find the requested resource" The code checks apierrors.IsNotFound however this doesn't handle if the CRD isn't installed. Use admiral's resource.IsNotFoundErr instead. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
fix_load_balancer
branch
from
0648bb9
to
5448f99
Compare
aswinsuryan
approved these changes
Jul 31, 2023
nyechiel
approved these changes
Jul 31, 2023
sridhargaddam
approved these changes
Jul 31, 2023
|
🤖 Closed branches: [z_pr2749/tpantelis/fix_load_balancer] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error:
The code checks
apierrors.IsNotFoundhowever this doesn't handle if the CRD isn't installed. Use admiral'sresource.IsNotFoundErrinstead.