-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provision GW LB service in accordance with OCP platform #2727
Conversation
🤖 Created branch: z_pr2727/yboaron/roks_lb |
b405e3d
to
8f0aa3d
Compare
ce29883
to
5d51dea
Compare
A LoadBalancer type Service is a typical way to expose an application to the internet. A LoadBalancer type Service relies on the cloud provider to create an external load balancer with an IP address in the relevant network space. Different cloud providers support different Service annotations, this PR updates LB service annotations in accordance with OCP platform. Fixes: submariner-io#2603 Signed-off-by: Yossi Boaron <[email protected]>
- apiGroups: | ||
- config.openshift.io | ||
resources: | ||
- infrastructures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the addon code, I see that we are configuring explicit access to "infrastructures/status"
Please check if similar thing needs to be done even here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I checked it on OCP (ROKS) cluster and it works without explicit access to "infrastructures/status",
also I can see that for example SRIOV operator doesn't specify infrastructure/status and use fields from infra/status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, explicit permissions on /status
sub-structs is only required for code which updates status information.
@yboaron Do you think this needs to be backported? And reminder about release notes, if they are needed. |
@dfarrell07 , this PR fixed a minor bug in ARO (unneeded annotation relevant for ROSA appears also in ARO) and adds ROKS support. Since ROKS support should start from 0.16 I don't think backport is needed here. |
@yboaron do you think this is worth mentioning in the release notes? It seems like an implementation detail. |
Yep, also think we shouldn't mention it in release notes. |
A LoadBalancer type Service relies on the cloud provider to create an external load balancer with an IP address in the relevant network space.
Different cloud providers support different Service annotations, this PR updates LB service annotations in accordance with OCP platform.
Fixes: #2603