Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OVNKubernetes CNI IC deployment support #2726

Merged
merged 3 commits into from
Jul 31, 2023

Conversation

aswinsuryan
Copy link
Contributor

@aswinsuryan aswinsuryan commented Jul 12, 2023

With OVN IC CNI 3 kind of deployment are possible

1)SIngle Zone (Or in non-ic deployment)

This is similar to the current deployment. Here a OVN Kubernetes db service will be running and it will be passed by submariner-operator to the routeagent/network plugin syncer code.

2)MultiZone and more than one node per zone.

In this case there will be no OVN db service will be present. But there will be an endpoint per zone. Submariner operator will pass the comma separated list of IP Port and protocol and the endpoint name to the route agent and networkpluginsyncer. The pod will chose one of them depending on the zone it is running

3)Multizone , one node per zone.

For this deployment there will be no service or endpoints. Submariner-Operator will pass the value local. The pods needs to use socket connection to program ovn.

Fixes: submariner-io/enhancements#191

This PR also passed the NBDB and SBDB values to the submariner-route agent daemon set as route agent will be now responsible for programming the OVN routes and policies.

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2726/aswinsuryan/ovn-ic-cni
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@aswinsuryan aswinsuryan marked this pull request as draft July 12, 2023 22:20
@aswinsuryan aswinsuryan marked this pull request as ready for review July 20, 2023 22:35
@aswinsuryan aswinsuryan marked this pull request as draft July 21, 2023 00:57
@aswinsuryan aswinsuryan force-pushed the ovn-ic-cni branch 6 times, most recently from 0e3531f to 376ac21 Compare July 21, 2023 18:07
@aswinsuryan aswinsuryan marked this pull request as ready for review July 21, 2023 18:19
Copy link
Member

@skitt skitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Printf tweak.

pkg/discovery/network/ovnkubernetes.go Outdated Show resolved Hide resolved
controllers/submariner/route_agent_resources.go Outdated Show resolved Hide resolved
pkg/discovery/network/ovnkubernetes.go Outdated Show resolved Hide resolved
pkg/discovery/network/ovnkubernetes.go Outdated Show resolved Hide resolved
pkg/discovery/network/ovnkubernetes.go Outdated Show resolved Hide resolved
pkg/discovery/network/ovnkubernetes.go Outdated Show resolved Hide resolved
pkg/discovery/network/ovnkubernetes.go Outdated Show resolved Hide resolved
Signed-off-by: Aswin Suryanarayanan <[email protected]>
* Removed SBDB configuration as we are not programming SBDB now
will be removed for all the cases once we compltely move to the new
implemnetation

* Fixed issues in naming

Signed-off-by: Aswin Suryanarayanan <[email protected]>
Copy link
Contributor

@tpantelis tpantelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix compile errors but otherwise looks good.

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Jul 31, 2023
Signed-off-by: Aswin Suryanarayanan <[email protected]>
@aswinsuryan aswinsuryan merged commit 060ea0c into submariner-io:devel Jul 31, 2023
37 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2726/aswinsuryan/ovn-ic-cni]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update the Submariner-operator to remove network-pulgin syncer deployment
4 participants