Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop filling in token/CA in the Submariner CR #2503

Closed
wants to merge 1 commit into from
Closed

Stop filling in token/CA in the Submariner CR #2503

wants to merge 1 commit into from

Conversation

skitt
Copy link
Member

@skitt skitt commented Feb 15, 2023 •
edited
Loading

This ensures we rely only on the secret containing the broker access token.

Fixes: #1869

Depends on submariner-io/releases#644
Depends on submariner-io/subctl#631

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2503/skitt/test-secret
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@github-actions
Copy link

github-actions bot commented Feb 15, 2023 •
edited
Loading

This PR/issue depends on:

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Feb 15, 2023
@dfarrell07
Copy link
Member

@skitt Why does this depend on RC0? Should it be the other way around, or am I missing something about why an API change should be after the RC?

@skitt
Copy link
Member Author

skitt commented Feb 16, 2023

@skitt Why does this depend on RC0? Should it be the other way around, or am I missing something about why an API change should be after the RC?

This depends on rc0 so that it isn’t included in 0.15. It will be merged to devel after we cut the 0.15 branch, so it will target 0.16 — I want to make sure it gets as much testing as possible before it gets released.

@tpantelis tpantelis enabled auto-merge (rebase) February 21, 2023 12:53
@stale
Copy link

stale bot commented Mar 18, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 18, 2023
@dfarrell07 dfarrell07 removed the wontfix This will not be worked on label Mar 21, 2023
@nyechiel
Copy link
Member

nyechiel commented May 4, 2023

@skitt is it the right time to merge this and move to the 0.16 board?

@skitt
Copy link
Member Author

skitt commented May 4, 2023

@skitt is it the right time to merge this and move to the 0.16 board?

This will break recover-broker-info, so we need to address that first (submariner-io/subctl#631).

@nyechiel
Copy link
Member

nyechiel commented May 4, 2023

@skitt is it the right time to merge this and move to the 0.16 board?

This will break recover-broker-info, so we need to address that first (submariner-io/subctl#631).

Is this planned for 0.16? It seems to be it in the backlog board at the moment

@skitt
Copy link
Member Author

skitt commented May 4, 2023

@skitt is it the right time to merge this and move to the 0.16 board?

This will break recover-broker-info, so we need to address that first (submariner-io/subctl#631).

Is this planned for 0.16? It seems to be it in the backlog board at the moment

We didn’t finish planning 0.16 yesterday...

@stale
Copy link

stale bot commented May 20, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 20, 2023
@dfarrell07 dfarrell07 removed the wontfix This will not be worked on label May 30, 2023
@stale
Copy link

stale bot commented Jun 18, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 18, 2023
@dfarrell07 dfarrell07 removed the wontfix This will not be worked on label Jun 20, 2023
@skitt @tpantelis
Stop filling in token/CA in the Submariner CR
3e2c058 
This ensures we rely only on the secret containing the broker access
token.

Fixes: submariner-io#1869
Signed-off-by: Stephen Kitt <[email protected]>
@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 17, 2023
@tpantelis
Copy link
Contributor

Is this still relevant?

@stale stale bot removed the wontfix This will not be worked on label Nov 3, 2023
@skitt skitt closed this Nov 6, 2023
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2503/skitt/test-secret]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpantelis tpantelis tpantelis approved these changes

@mkolesnik mkolesnik mkolesnik approved these changes

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

Assignees
No one assigned
Labels
dependent ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop publishing sensitive information directly in CRs
6 participants
@skitt @submariner-bot @dfarrell07 @nyechiel @tpantelis @mkolesnik